General

Does the code work? Does it perform its intended function, the logic is correct etc.

程序能正常运行，各个功能都完整。

Is all the code easily understood?

代码结构清晰，好好儿解释代码。

Does it conform to your agreed coding conventions? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.

看来他的代码跟厉害，看他的代码学的很多了。

Is there any redundant or duplicate code?

Generate和Compute函数的功能很多了，这两个函数可以在模块化一些。

Is the code as modular as possible?

没有划分模块

Can any global variables be replaced?

全局变量比较合适

Is there any commented out code?

代码都比较干净找不到删除的地方

Do loops have a set length and correct termination conditions?

正常结束

Can any of the code be replaced with library functions?

可以用到库函数

Can any logging or debugging code be removed?

没有的

Security

Are all data inputs checked (for the correct type, length, format, and range) and encoded?

都做到了

Where third-party utilities are used, are returning errors being caught?

未使用

Are output values checked and encoded?

都正确

Are invalid parameter values handled?

输入错的话不进行，并结束程序

Documentation

Do comments exist and describe the intent of the code?

没有写文档

Are all functions commented?

没有写文档

Is any unusual behavior or edge-case handling described?

没有写文档

Is the use and function of third-party libraries documented?

没有写文档

Are data structures and units of measurement explained?

没有写文档

Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?

没有写文档

Testing

Is the code testable? i.e. don’t add too many or hide dependencies, unable to initialize objects, test frameworks can use methods etc.

代码可以测试

Do tests exist and are they comprehensive? i.e. has at least your agreed on code coverage.

没有设计测试代码

Do unit tests actually test that the code is performing the intended functionality?

没有设计测试代码

Are arrays checked for ‘out-of-bound’ errors?

没有进行数组越界检查

Could any test code be replaced with the use of an existing API?

没有设计测试代码